Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellation fixes and tests. #445

Merged
merged 21 commits into from
Sep 15, 2023
Merged

Cancellation fixes and tests. #445

merged 21 commits into from
Sep 15, 2023

Commits on Sep 9, 2023

  1. Add callTick and stream cancellation tests.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    0e2c198 View commit details
    Browse the repository at this point in the history

  2. Fix stepsAsync() test.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2c1e665 View commit details
    Browse the repository at this point in the history

  3. Cancellation changes.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    4d2f8d7 View commit details
    Browse the repository at this point in the history

  4. Update and add more cancellation tests.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    b6597eb View commit details
    Browse the repository at this point in the history

  5. Fix Posix shutdown call to handle ENOTCONN error.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    17a6f58 View commit details
    Browse the repository at this point in the history

  6. With new changes to to cancellation its now possible.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    b16d4dc View commit details
    Browse the repository at this point in the history

  7. Refactor testsoon.nim to not produce artifacts after tests are finished.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2c66cca View commit details
    Browse the repository at this point in the history

  8. Debugging MacOS issue.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    49ba589 View commit details
    Browse the repository at this point in the history

  9. Adjust flaky test times.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    9efed95 View commit details
    Browse the repository at this point in the history

  10. Fix issue.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    d3f45d7 View commit details
    Browse the repository at this point in the history

  11. Add test for issue #334 which was also addressed in this PR. 

    Avoid `break` in problematic test.
    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    adda289 View commit details
    Browse the repository at this point in the history

  12. Add noCancelWait() call which prohibits cancellation. 

    Fix closeWait() calls to use noCancelWait() predicate.
Adding sleep to flaky MacOS test.
    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    2f5e823 View commit details
    Browse the repository at this point in the history

  13. Remove all debugging echoes.

    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    9c63541 View commit details
    Browse the repository at this point in the history

  14. Fix cancelAndWait() which now could perform multiple attempts to canc… 

    …el target Future (mustCancel behavior).
    @cheatfate
    cheatfate committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    772a7d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Fix issues revealed by switch to different cancelAndWait().

    @cheatfate
    cheatfate committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    e8995ea View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Address review comments.

    @cheatfate
    cheatfate committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6731bcd View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Fix testutils compilation warning.

    @cheatfate
    cheatfate committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7e3682f View commit details
    Browse the repository at this point in the history

  2. Rename callTick() to internalCallTick().

    @cheatfate
    cheatfate committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c2807cc View commit details
    Browse the repository at this point in the history

  3. Add some documentation comments.

    @cheatfate
    cheatfate committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2231ca1 View commit details
    Browse the repository at this point in the history

  4. Disable flaky ratelimit test.

    @cheatfate
    cheatfate committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    04d8353 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Rename noCancelWait() to noCancel(). 

    Address review comments.
    @cheatfate
    cheatfate committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    947847c View commit details
    Browse the repository at this point in the history