training with pytorch lightning #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 186bf87.
|
Thanks for this PR. I'm very curious to hear if you can share anything about the performance you get with this FSDP training loop in terms of tokens per second on a particular model config and hardware (single GPU, single node, or cluster). |
albertfgu
force-pushed
the
main
branch
2 times, most recently
from
6d45666
to
41d30ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR provides FSDP training using pytorch lightning. The current model setup provides a byte level model. I'm not sure it makes sense to merge in this state, but it might provide a nice starting point for others who want to implement FSDP training.