-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutable Component Config (SRC-107) #107
base: main
Are you sure you want to change the base?
Conversation
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
Hey @ericnordelo can you add the mandatory section "Rationale" (IMO you could simply rename the section "Motivation" which is optional) and "Security considerations"? |
Hey @leo-starkware, sorry for the delay. Updates applied! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the file name to "snip-23", as well as in line 2 "snip: 23". After that let's merge
What is the rationale behind the 23? It is not easier to track SNIPs by the PR number (like EIPs) so they can be safely referenced when they are drafts? We are also already referencing this in the library as SRC-107. |
Discussion:
https://community.starknet.io/t/immutable-component-config/114434
Abstract
This standard proposes a mechanism to allow setting components’ configurable constants in the implementing contracts
without needing to save them in storage. Component providers can leverage this standard to make them configurable while
keeping the constants hardcoded in the bytecode, removing the extra storage reads required if storage were to be used for
this matter.
SNIP number
I followed the PR number pattern to assign 107.