docs(README): fix code sample and describe forPrimitives #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While resolving a different issue, I didn't immediately understand the
forPrimitives
option, and it wasn't documented anywhere, so I figured it out by looking at the one place where it's used, and looking up the documentation forsquire
and noticed a glaring issue on the README - in the readme,createFilter
is used, but no such function exists, andcreateFactory
is the correct function.Other notes
I also would love to have custom operators to have better typing, like the following snippet: