Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(helm-docs): fix diff issue in GitHub action check #362

Merged
merged 15 commits into from
Nov 15, 2024
Merged

ci(helm-docs): fix diff issue in GitHub action check #362

merged 15 commits into from
Nov 15, 2024
+8 −7

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Nov 15, 2024 •
edited
Loading

  • Action: Fix output-file option
  • Pre-commit/Action: Remove options that uses the default value
  • Use git diff instead of action fail-on-diff (not working for some reason)
  • Add missing changes to readme
  • Remove helm-docs.versionFooter template call
  • Add comments to remember to keep in sync helm-docs options

@aslafy-z aslafy-z changed the title ci: make sure readme diff works ci(helm-docs): fix diff issue in GitHub action check Nov 15, 2024
@aslafy-z aslafy-z marked this pull request as ready for review November 15, 2024 10:54
@aslafy-z aslafy-z merged commit 2c97270 into master Nov 15, 2024
2 of 3 checks passed
@aslafy-z aslafy-z deleted the aslafy-z-patch-3 branch November 15, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aslafy-z