Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: detect pnpm from package.json #25

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

AriPerkkio
Copy link
Member

I got the 9.4.0 version from:

pnpm 9.4.0
nodejs 18.20.3

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • I have added tests for this change

Comment on lines +17 to +18
- name: Checkout
uses: actions/checkout@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be run before pnpm/action-setup so that package.json is present on file system and version can be resolved from there.

@AriPerkkio AriPerkkio requested a review from d3lm July 18, 2024 09:23
@d3lm
Copy link
Collaborator

d3lm commented Jul 18, 2024

So the reason we use pnpm@8 still is that we still need to update pnpm for WebContainer and we are not yet on v9.

@AriPerkkio
Copy link
Member Author

@d3lm do you think we should use pnpm@8 here too? The current lockfile in main is generated with pnpm@9 so we'll need to re-generate that if it's wanted.

@d3lm
Copy link
Collaborator

d3lm commented Jul 18, 2024

I mean unless we want people to send reproductions with StackBlitz which would be really cool. If yes, then I think we should lock it to the version that we currently support on StackBlitz.com. WDYT?

@AriPerkkio
Copy link
Member Author

Yep that makes sense. I've now lowered the pnpm to v8 and re-generated lockfile.

@AriPerkkio AriPerkkio requested a review from d3lm July 18, 2024 14:36
@d3lm d3lm merged commit 43326eb into stackblitz:main Jul 22, 2024
2 checks passed
@AriPerkkio AriPerkkio deleted the ci/detect-pnpm branch July 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants