-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: detect pnpm
from package.json
#25
Conversation
- name: Checkout | ||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be run before pnpm/action-setup
so that package.json
is present on file system and version can be resolved from there.
So the reason we use pnpm@8 still is that we still need to update pnpm for WebContainer and we are not yet on v9. |
@d3lm do you think we should use |
I mean unless we want people to send reproductions with StackBlitz which would be really cool. If yes, then I think we should lock it to the version that we currently support on StackBlitz.com. WDYT? |
Yep that makes sense. I've now lowered the |
pnpm
versions. The lockfile is generated bypnpm@9
but CI is usingpnpm@8
.packageManager
intopackage.json
so thatpnpm/action-setup
can automatically detect it. Similar to ci: detectpnpm
version frompackage.json
tutorialkit#101.I got the
9.4.0
version from:eslint-plugin/.tool-versions
Lines 1 to 2 in d665151
Checklist