Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mlm:artifact_type check missing in assets and other disallowed MLM fields #59

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

fmigneault
Copy link
Collaborator

Description

  • Improve the README regarding allowed/disallowed fields in the Assets vs Item vs both.
  • Align the allowed/disallowed fields behavior with the JSON schema
  • Ensure that, for the Asset that contains the mlm:model role, the mlm:artifact_type is also provided
  • Add multiple tests validating above behaviors

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing mlm:artifact_type in JSON schema
1 participant