Implement upload of results #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 78.82% 77.88% -0.94%
==========================================
Files 8 8
Lines 680 710 +30
==========================================
+ Hits 536 553 +17
- Misses 144 157 +13 ☔ View full report in Codecov by Sentry. |
lkeegan
force-pushed
the
refactor_admin_view
branch
from
c89c528
to
2e48216
Compare
- runner creates three folders where the script runs, and uploads their contents as zipfiles: - `/user_results`: provided to user - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin - `/admin_results`: only visible to admins - admin results are always uploaded, included for failed runs (for debugging) - user results are only provided if the run was successful - add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found - add /admin/result endpoint to download admin results zipfile - switch from micromamba to miniconda docker image - reticulate doesn't seem to support micromamba, at least within docker - re-enable runner docker image CI - update runner README.md - resolves #6 - resolves #43 Also refactor admin views using tabs
lkeegan
force-pushed
the
refactor_admin_view
branch
from
2e48216
to
844151e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/user_results: provided to user/trusted_user_results: provided to user if they have "full results" enabled by an admin/admin_results: only visible to adminsPREDICTCR_RUNNER_SCRIPT_DIRenv var to docker compose to specify where script & model can be foundAlso refactor admin views using tabs