Rename to allowConstraintErrors

docs/source-2.0/spec/documentation-traits.rst

@@ -139,7 +139,7 @@ Each ``example`` trait value is a structure with the following members:
       - :ref:`examples-ErrorExample-structure`
       - Provides an error shape ID and example error parameters for the
         operation.
-    * - disableConstraints
+    * - allowConstraintErrors
       - ``boolean``
       - Set to true to lower input constraint trait validations to warnings.
         This can only be set when ``error`` is provided.
@@ -186,7 +186,7 @@ MUST NOT be defined for the same example.
                     message: "Invalid 'foo'. Special character not allowed."
                 }
             },
-            disableConstraints: true
+            allowConstraintErrors: true
         }
     ])
 

smithy-model/src/main/java/software/amazon/smithy/model/traits/ExamplesTrait.java

@@ -119,15 +119,15 @@ public static final class Example implements ToNode, ToSmithyBuilder<Example> {
         private final ObjectNode input;
         private final ObjectNode output;
         private final ErrorExample error;
-        private final boolean disableConstraints;
+        private final boolean allowConstraintErrors;
 
         private Example(Builder builder) {
             this.title = Objects.requireNonNull(builder.title, "Example title must not be null");
             this.documentation = builder.documentation;
             this.input = builder.input;
             this.output = builder.output;
             this.error = builder.error;
-            this.disableConstraints = builder.disableConstraints;
+            this.allowConstraintErrors = builder.allowConstraintErrors;
         }
 
         /**
@@ -166,10 +166,10 @@ public Optional<ErrorExample> getError() {
         }
 
         /**
-         * @return Returns true if input constraints validation has been disabled.
+         * @return Returns true if input constraints errors are allowed.
          */
-        public boolean getDisableConstraints() {
-            return disableConstraints;
+        public boolean getAllowConstraintErrors() {
+            return allowConstraintErrors;
         }
 
         @Override
@@ -178,7 +178,8 @@ public Node toNode() {
                     .withMember("title", Node.from(title))
                     .withOptionalMember("documentation", getDocumentation().map(Node::from))
                     .withOptionalMember("error", getError().map(ErrorExample::toNode))
-                    .withOptionalMember("disableConstraints", BooleanNode.from(disableConstraints).asBooleanNode());
+                    .withOptionalMember("allowConstraintErrors", BooleanNode.from(allowConstraintErrors)
+                            .asBooleanNode());
 
             if (!input.isEmpty()) {
                 builder.withMember("input", input);
@@ -193,7 +194,7 @@ public Node toNode() {
         @Override
         public Builder toBuilder() {
             return new Builder().documentation(documentation).title(title).input(input).output(output).error(error)
-                    .disableConstraints(disableConstraints);
+                    .allowConstraintErrors(allowConstraintErrors);
         }
 
         public static Builder builder() {
@@ -209,7 +210,7 @@ public static final class Builder implements SmithyBuilder<Example> {
             private ObjectNode input = Node.objectNode();
             private ObjectNode output;
             private ErrorExample error;
-            private boolean disableConstraints;
+            private boolean allowConstraintErrors;
 
             @Override
             public Example build() {
@@ -241,8 +242,8 @@ public Builder error(ErrorExample error) {
                 return this;
             }
 
-            public Builder disableConstraints(Boolean disableConstraints) {
-                this.disableConstraints = disableConstraints;
+            public Builder allowConstraintErrors(Boolean allowConstraintErrors) {
+                this.allowConstraintErrors = allowConstraintErrors;
                 return this;
             }
         }
@@ -339,7 +340,7 @@ private static Example exampleFromNode(ObjectNode node) {
                     .getObjectMember("input", builder::input)
                     .getObjectMember("output", builder::output)
                     .getMember("error", ErrorExample::fromNode, builder::error)
-                    .getBooleanMember("disableConstraints", builder::disableConstraints);
+                    .getBooleanMember("allowConstraintErrors", builder::allowConstraintErrors);
             return builder.build();
         }
     }

smithy-model/src/main/java/software/amazon/smithy/model/validation/NodeValidationVisitor.java

@@ -110,7 +110,7 @@ public enum Feature {
         RANGE_TRAIT_ZERO_VALUE_WARNING,
 
         // Lowers severity of constraint trait validations to WARNING.
-        DISABLE_CONSTRAINTS;
+        ALLOW_CONSTRAINT_ERRORS;
 
         public static Feature fromNode(Node node) {
             return Feature.valueOf(node.expectStringNode().getValue());
@@ -328,7 +328,7 @@ public List<ValidationEvent> structureShape(StructureShape shape) {
 
                     for (MemberShape member : members.values()) {
                         if (member.isRequired() && !object.getMember(member.getMemberName()).isPresent()) {
-                            Severity severity = this.validationContext.hasFeature(Feature.DISABLE_CONSTRAINTS)
+                            Severity severity = this.validationContext.hasFeature(Feature.ALLOW_CONSTRAINT_ERRORS)
                                     ? Severity.WARNING : Severity.ERROR;
                             events.add(event(String.format(
                                     "Missing required structure member `%s` for `%s`",

smithy-model/src/main/java/software/amazon/smithy/model/validation/node/BlobLengthPlugin.java

@@ -57,7 +57,7 @@ protected void check(Shape shape, LengthTrait trait, StringNode node, Context co
     }
 
     private Severity getSeverity(Context context) {
-        return context.hasFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS)
+        return context.hasFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS)
                 ? Severity.WARNING : Severity.ERROR;
     }
 }

smithy-model/src/main/java/software/amazon/smithy/model/validation/node/MapLengthPlugin.java

@@ -53,7 +53,7 @@ protected void check(Shape shape, LengthTrait trait, ObjectNode node, Context co
     }
 
     private Severity getSeverity(Context context) {
-        return context.hasFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS)
+        return context.hasFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS)
                 ? Severity.WARNING : Severity.ERROR;
     }
 }

smithy-model/src/main/java/software/amazon/smithy/model/validation/node/PatternTraitPlugin.java

@@ -42,7 +42,7 @@ protected void check(Shape shape, PatternTrait trait, StringNode node, Context c
 
 
     private Severity getSeverity(Context context) {
-        return context.hasFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS)
+        return context.hasFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS)
                 ? Severity.WARNING : Severity.ERROR;
     }
 }

smithy-model/src/main/java/software/amazon/smithy/model/validation/node/RangeTraitPlugin.java

@@ -97,12 +97,12 @@ protected void check(Shape shape, Context context, RangeTrait trait, NumberNode
     private Severity getSeverity(NumberNode node, Context context) {
         boolean zeroValueWarning = context
                 .hasFeature(NodeValidationVisitor.Feature.RANGE_TRAIT_ZERO_VALUE_WARNING);
-        boolean rangeTraitWarning = context.hasFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS);
+        boolean rangeTraitWarning = context.hasFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS);
         return (zeroValueWarning && node.isZero()) || rangeTraitWarning ? Severity.WARNING : Severity.ERROR;
     }
 
     private Severity getSeverity(Context context) {
-        return context.hasFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS)
+        return context.hasFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS)
                 ? Severity.WARNING : Severity.ERROR;
     }
 }

smithy-model/src/main/java/software/amazon/smithy/model/validation/node/StringLengthPlugin.java

@@ -51,7 +51,7 @@ protected void check(Shape shape, LengthTrait trait, StringNode node, Context co
     }
 
     private Severity getSeverity(Context context) {
-        return context.hasFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS)
+        return context.hasFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS)
                 ? Severity.WARNING : Severity.ERROR;
     }
 }

smithy-model/src/main/java/software/amazon/smithy/model/validation/validators/ExamplesTraitValidator.java

@@ -52,9 +52,9 @@ private List<ValidationEvent> validateExamples(Model model, OperationShape shape
 
             model.getShape(shape.getInputShape()).ifPresent(input -> {
                 NodeValidationVisitor validator;
-                if (example.getDisableConstraints() && !isErrorDefined) {
+                if (example.getAllowConstraintErrors() && !isErrorDefined) {
                     events.add(error(shape, trait, String.format(
-                            "Example: `%s` has disableConstraints enabled, so error must be defined.",
+                            "Example: `%s` has allowConstraintErrors enabled, so error must be defined.",
                             example.getTitle())));
                 }
                 validator = createVisitor("input", example.getInput(), model, shape, example);
@@ -103,8 +103,8 @@ private NodeValidationVisitor createVisitor(
                 .value(value)
                 .startingContext("Example " + name + " of `" + example.getTitle() + "`")
                 .eventId(getName());
-        if (example.getDisableConstraints()) {
-            builder.addFeature(NodeValidationVisitor.Feature.DISABLE_CONSTRAINTS);
+        if (example.getAllowConstraintErrors()) {
+            builder.addFeature(NodeValidationVisitor.Feature.ALLOW_CONSTRAINT_ERRORS);
         }
         return builder.build();
     }

smithy-model/src/main/resources/software/amazon/smithy/model/loader/prelude.smithy

@@ -364,7 +364,7 @@ structure Example {
 
     error: ExampleError
 
-    disableConstraints: Boolean
+    allowConstraintErrors: Boolean
 }
 
 @private

smithy-model/src/test/java/software/amazon/smithy/model/traits/ExamplesTraitTest.java

@@ -41,7 +41,7 @@ public void loadsTrait() {
                         .withMember("error", Node.objectNode()
                                 .withMember(Node.from("shapeId"), Node.from("smithy.example#FooError"))
                                 .withMember(Node.from("content"), Node.objectNode().withMember("e", Node.from("f"))))
-                        .withMember("disableConstraints", Node.from(true)));
+                        .withMember("allowConstraintErrors", Node.from(true)));
 
         Optional<Trait> trait = provider.createTrait(
                 ShapeId.from("smithy.api#examples"), ShapeId.from("ns.qux#foo"), node);

smithy-model/src/test/resources/software/amazon/smithy/model/errorfiles/validators/examples-trait-validator.errors

@@ -6,7 +6,7 @@
 [WARNING] ns.foo#Operation: Example output of `Testing 2`: Invalid structure member `additional` found for `ns.foo#OperationOutput` | ExamplesTrait
 [ERROR] ns.foo#Operation: Example output of `Testing 2`: Missing required structure member `bam` for `ns.foo#OperationOutput` | ExamplesTrait
 [WARNING] ns.foo#Operation: Example error of `Testing 1`: Invalid structure member `extra` found for `ns.foo#OperationError` | ExamplesTrait
-[ERROR] ns.foo#Operation: Example: `Testing 4` has disableConstraints enabled, so error must be defined. | ExamplesTrait
+[ERROR] ns.foo#Operation: Example: `Testing 4` has allowConstraintErrors enabled, so error must be defined. | ExamplesTrait
 [WARNING] ns.foo#Operation: Example input of `Testing 5`.blobMin: Value provided for `ns.foo#OperationInput$blobMin` must have at least 3 bytes, but the provided value only has 1 bytes | ExamplesTrait
 [WARNING] ns.foo#Operation: Example input of `Testing 5`.blobMax: Value provided for `ns.foo#OperationInput$blobMax` must have no more than 3 bytes, but the provided value has 6 bytes | ExamplesTrait
 [WARNING] ns.foo#Operation: Example input of `Testing 5`: Missing required structure member `foo` for `ns.foo#OperationInput` | ExamplesTrait

smithy-model/src/test/resources/software/amazon/smithy/model/errorfiles/validators/examples-trait-validator.json

@@ -62,7 +62,7 @@
                         "output": {
                             "bam": "value3"
                         },
-                        "disableConstraints": true
+                        "allowConstraintErrors": true
                     },
                     {
                         "title": "Testing 5",
@@ -91,7 +91,7 @@
                                 "bat": "baz"
                             }
                         },
-                        "disableConstraints": true
+                        "allowConstraintErrors": true
                     }
                 ]
             }