This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Order Events by time/data fields. #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events can be ordered by the time or any of its data fields by adding an
'order=field' parameter to the query. 'order=-time' is the default.
Descending order can be specified by prepending "-" to the field name.
If the ordering field is "time" the field name is transformed to "t",
otherwise it is transformed to "d.{field_name}".
The tests revealed a bug in the previous commit which added the order parameter, which has now been fixed.
|
I'm not much of a JS developer so it took me some time to wrap my head around all of the callbacks in the unit tests, but I managed to write some tests for events. The tests even exposed a problem in my pull request. |
|
Is there anything I might change with this PR to help it get merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events can be ordered by the time or any of its data fields by adding an
'order=field' parameter to the query. 'order=-time' is the default.
Descending order can be specified by prepending "-" to the field name.
If the ordering field is "time" the field name is transformed to "t",
otherwise it is transformed to "d.{field_name}".
Fixes #79
(Resubmitting with the correct git user, sorry for the noise)