Fix places where the parameterPlaceholder
is hardcoded to a ?
#592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are places where the
parameterPlaceholder
variable isn't used and the?
(question mark) is hardcoded in code.This prevents the redefinition of the
parameterPlaceholder
to another value.Practical usage:
It is not possible to define JSON (Postgres) specific queries because some of the keywords use the question mark.
Example:
The
?
gets interpreted as a parameter and throws an exception.With the changes in place the
parameterPlaceholder
can be redefined to use another value, for example the$$
value can be used insetad by inheriting a new class from e.g. PostgresCompiler:Now the query works as expected after all desired occurrences of
?
are replaced with$$
in your code.