Merge pull request #97 from spree/remove-promo-code-without-name

Add possibility to remove all promo codes without specific code name
spree · May 15, 2019 · a92f2c7 · a92f2c7
2 parents 32482ef + 3d4f751
commit a92f2c7
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -471,9 +471,9 @@ Removes a coupon code from the Cart.
 
 __Required token:__ [Bearer token](#bearer-token) or [Order token](#order-token)
 
-__Parameters schema:__
+__Optional parameters schema:__
 ```ts
-coupon_code: string
+coupon_code?: string
 ```
 
 __Success response schema:__ [Success schema](#success-schema)

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@spree/storefront-api-v2-sdk",
-  "version": "2.1.4",
+  "version": "2.2.0",
   "description": "Node module to easily integrate your JavaScript or TypeScript application with Spree API V2. You can create an entirely custom Storefront in JS/TS with this package including one page checkout, Single Page Apps, PWAs and so on",
   "engines": {
     "node": ">=8",

diff --git a/src/endpoints/Cart.ts b/src/endpoints/Cart.ts
@@ -36,8 +36,16 @@ export default class Cart extends Http {
     return await this.spreeResponse(PATCH, Routes.cartApplyCodePath(), token, params) as IOrderResult
   }
 
-  public async removeCouponCode(token: IToken, code: string, params: IQuery = {}): Promise<IOrderResult> {
-    return await this.spreeResponse(PATCH, Routes.cartRemoveCodePath(code), token, params) as IOrderResult
+  public async removeCouponCode(token: IToken, code: string = null, params: IQuery = {}): Promise<IOrderResult> {
+    let route = ''
+
+    if (code !== null) {
+      route = Routes.cartRemoveCodePath(code)
+    } else {
+      route = Routes.cartRemoveCodePath('')
+    }
+
+    return await this.spreeResponse(DELETE, route, token, params) as IOrderResult
   }
 
   public async estimateShippingMethods(

diff --git a/src/routes.ts b/src/routes.ts
@@ -13,7 +13,7 @@ export const Routes = {
   cartEmptyPath: () => `${storefrontPath}/cart/empty`,
   cartSetItemQuantity: () => `${storefrontPath}/cart/set_quantity`,
   cartApplyCodePath: () => `${storefrontPath}/cart/apply_coupon_code`,
-  cartRemoveCodePath: (code: string) => `${storefrontPath}/cart/remove_coupon_code/${code}`,
+  cartRemoveCodePath: (code?: string) => `${storefrontPath}/cart/remove_coupon_code/${code}`,
   cartEstimateShippingMethodsPath: () => `${storefrontPath}/cart/estimate_shipping_rates`,
   checkoutPath: () => `${storefrontPath}/checkout`,
   checkoutNextPath: () => `${storefrontPath}/checkout/next`,

diff --git a/types/endpoints/Cart.d.ts b/types/endpoints/Cart.d.ts
@@ -12,6 +12,6 @@ export default class Cart extends Http {
     emptyCart(token: IToken, params?: IQuery): Promise<IOrderResult>;
     setQuantity(token: IToken, params: SetQuantity): Promise<IOrderResult>;
     applyCouponCode(token: IToken, params: CouponCode): Promise<IOrderResult>;
-    removeCouponCode(token: IToken, code: string, params?: IQuery): Promise<IOrderResult>;
+    removeCouponCode(token: IToken, code?: string, params?: IQuery): Promise<IOrderResult>;
     estimateShippingMethods(token: IToken, params: EstimateShippingMethods): Promise<IEstimatedShippingMethodsResult>;
 }
diff --git a/types/routes.d.ts b/types/routes.d.ts
@@ -11,7 +11,7 @@ export declare const Routes: {
     cartEmptyPath: () => string;
     cartSetItemQuantity: () => string;
     cartApplyCodePath: () => string;
-    cartRemoveCodePath: (code: string) => string;
+    cartRemoveCodePath: (code?: string) => string;
     cartEstimateShippingMethodsPath: () => string;
     checkoutPath: () => string;
     checkoutNextPath: () => string;