feat(pipeline_template): Jinja rendering in triggers, params and noti…

…fications (#1619)

orca-pipelinetemplate/src/main/java/com/netflix/spinnaker/orca/pipelinetemplate/v1schema/V1SchemaExecutionGenerator.java

@@ -51,6 +51,7 @@ public Map<String, Object> generate(PipelineTemplate template, TemplateConfigura
     }
 
     addNotifications(pipeline, template, configuration);
+    addParameters(pipeline, template, configuration);
 
     pipeline.put("stages", template.getStages()
       .stream()
@@ -91,4 +92,21 @@ private void addNotifications(Map<String, Object> pipeline, PipelineTemplate tem
       );
     }
   }
+
+  private void addParameters(Map<String, Object> pipeline, PipelineTemplate template, TemplateConfiguration configuration) {
+    if (configuration.getConfiguration().getInherit().contains("parameters")) {
+      pipeline.put(
+        "parameterConfig",
+        TemplateMerge.mergeNamedContent(
+          template.getConfiguration().getParameters(),
+          configuration.getConfiguration().getParameters()
+        )
+      );
+    } else {
+      pipeline.put(
+        "parameterConfig",
+        Optional.ofNullable(configuration.getConfiguration().getParameters()).orElse(Collections.emptyList())
+      );
+    }
+  }
 }

orca-pipelinetemplate/src/main/java/com/netflix/spinnaker/orca/pipelinetemplate/v1schema/graph/transform/RenderTransform.java

@@ -20,6 +20,7 @@
 import com.netflix.spinnaker.orca.pipelinetemplate.exceptions.IllegalTemplateConfigurationException;
 import com.netflix.spinnaker.orca.pipelinetemplate.exceptions.TemplateRenderException;
 import com.netflix.spinnaker.orca.pipelinetemplate.v1schema.PipelineTemplateVisitor;
+import com.netflix.spinnaker.orca.pipelinetemplate.v1schema.model.NamedHashMap;
 import com.netflix.spinnaker.orca.pipelinetemplate.v1schema.model.PartialDefinition;
 import com.netflix.spinnaker.orca.pipelinetemplate.v1schema.model.PipelineTemplate;
 import com.netflix.spinnaker.orca.pipelinetemplate.v1schema.model.StageDefinition;
@@ -74,6 +75,15 @@ private void render(PipelineTemplate template) {
 
     // We don't care about configuration partials, they were already merged into the template at this point
     renderPartials(template.getPartials(), filterStages(template.getStages(), true), context);
+
+    renderConfigurations(template.getConfiguration().getParameters(), context, "template:configuration.parameters");
+    renderConfigurations(templateConfiguration.getConfiguration().getParameters(), context, "configuration:configuration.parameters");
+
+    renderConfigurations(template.getConfiguration().getTriggers(), context, "template:configuration.triggers");
+    renderConfigurations(templateConfiguration.getConfiguration().getTriggers(), context, "configuration:configuration.triggers");
+
+    renderConfigurations(template.getConfiguration().getNotifications(), context, "template:configuration.notifications");
+    renderConfigurations(templateConfiguration.getConfiguration().getNotifications(), context, "configuration:configuration.notifications");
   }
 
   private void renderStages(List<StageDefinition> stages, RenderContext context, String locationNamespace) {
@@ -196,4 +206,25 @@ private void renderPartials(List<PartialDefinition> partials, List<StageDefiniti
       partial.getRenderedPartials().put(stage.getId(), renderedStages);
     }
   }
+
+  private void renderConfigurations(List<NamedHashMap> configurations, RenderContext context, String location) {
+    if (configurations == null) {
+      return;
+    }
+
+    for (Map<String, Object> config : configurations) {
+      for (Map.Entry<String, Object> pair : config.entrySet()) {
+        try {
+          pair.setValue(RenderUtil.deepRender(renderer, pair.getValue(), context));
+        } catch (TemplateRenderException e) {
+          throw TemplateRenderException.fromError(
+            new Error()
+              .withMessage("Failed rendering configuration property")
+              .withLocation(location),
+            e
+          );
+        }
+      }
+    }
+  }
 }

orca-pipelinetemplate/src/test/groovy/com/netflix/spinnaker/orca/pipelinetemplate/PipelineTemplatePipelinePreprocessorSpec.groovy

@@ -152,7 +152,8 @@ class PipelineTemplatePipelinePreprocessorSpec extends Specification {
           requisiteStageRefIds: ['tagImage'],
           waitTime: 5
         ]
-      ]
+      ],
+      parameterConfig: []
     ]
     assertReflectionEquals(expected, result, ReflectionComparatorMode.IGNORE_DEFAULTS)
   }

orca-pipelinetemplate/src/test/resources/integration/v1schema/conditionalStage-expected.json

@@ -5,5 +5,6 @@
   "application": "orca",
   "name": "Unnamed Execution",
   "stages": [],
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/inheritance-expected.json

@@ -30,5 +30,6 @@
     }
   ],
   "id": "unknown",
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/modules-expected.json

@@ -35,5 +35,6 @@
       ]
     }
   ],
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/partials-expected.json

@@ -40,5 +40,6 @@
       "waitTime": 5
     }
   ],
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/partialsAndModules-expected.json

@@ -31,5 +31,6 @@
       "waitTime": 5
     }
   ],
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/simple-expected.json

@@ -5,5 +5,6 @@
   "application": "orca",
   "name": "Unnamed Execution",
   "stages": [],
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/stageInjection-expected.json

@@ -62,5 +62,6 @@
     }
   ],
   "id": "unknown",
-  "notifications": []
+  "notifications": [],
+  "parameterConfig": []
 }

orca-pipelinetemplate/src/test/resources/integration/v1schema/variableParameters-config.yml

@@ -0,0 +1,7 @@
+---
+schema: "1"
+pipeline:
+  application: orca
+configuration:
+  inherit: ['parameters']
+stages: []

orca-pipelinetemplate/src/test/resources/integration/v1schema/variableParameters-expected.json

@@ -0,0 +1,16 @@
+{
+  "id": "unknown",
+  "keepWaitingPipelines": false,
+  "limitConcurrent": true,
+  "application": "orca",
+  "name": "Unnamed Execution",
+  "stages": [],
+  "notifications": [],
+  "parameterConfig": [
+    {
+      "name": "instances",
+      "description": "Number of instances to start per region",
+      "default": 3
+    }
+  ]
+}

orca-pipelinetemplate/src/test/resources/integration/v1schema/variableParameters-template.yml

@@ -0,0 +1,16 @@
+---
+schema: "1"
+id: variableParameters
+metadata:
+  name: Variable Parameters
+  description: Asserts that variables can be used in parameters.
+configuration:
+  parameters:
+  - name: instances
+    description: Number of instances to start per region
+    default: "{{ instances }}"
+variables:
+- name: instances
+  description: The number of instances to start per region
+  defaultValue: 3
+stages: []