Skip to content

Commit

Permalink
fix(integration/test): increase container startup time (#4754)
Browse files Browse the repository at this point in the history
to avoid failures like https://github.com/spinnaker/orca/actions/runs/9507661382/job/26207523266

PostgresMigrationContainerTest > testHealthCheckWithPostgres() FAILED
    org.testcontainers.containers.ContainerLaunchException: Container startup failed for image us-docker.pkg.dev/spinnaker-community/docker/orca:8.36.3-dev-release-1.32.x-3f8965d03-202406101625-unvalidated

also changing the timeout in BaseContainerTest to avoid failures testing locally.
  • Loading branch information
dbyron-sf authored Jun 25, 2024
1 parent b1d12c0 commit 33a7db3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ void init(TestInfo testInfo) throws Exception {
new GenericContainer(dockerImageName)
.withNetwork(network)
.withExposedPorts(ORCA_PORT)
.waitingFor(Wait.forHealthcheck().withStartupTimeout(Duration.ofSeconds(120)));
.waitingFor(Wait.forHealthcheck().withStartupTimeout(Duration.ofSeconds(150)));
}

void testHealthCheck() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ void setup() throws Exception {
new GenericContainer(previousDockerImageName)
.withNetwork(network)
.withExposedPorts(ORCA_PORT)
.waitingFor(Wait.forHealthcheck().withStartupTimeout(Duration.ofSeconds(120)))
.waitingFor(Wait.forHealthcheck().withStartupTimeout(Duration.ofSeconds(150)))
.dependsOn(postgres)
.withEnv("SPRING_APPLICATION_JSON", getSpringApplicationJson());
orcaInitialContainer.start();
Expand Down

0 comments on commit 33a7db3

Please sign in to comment.