Skip to content

Commit

Permalink
chore(deps): Upgrade golangci-lint (#141)
Browse files Browse the repository at this point in the history
* chore(deps): Upgrade golangci-lint

Also, the documentation recommends running it separately from
other jobs so that they run in parallel.  The main reason I'm
doing that here is because there are a lot of warnings in the
logs that I think are because it is expecting to start with
a clean working environment, which is not the case when it
runs after our other checks.

* chore(dependencies): Use v2 of the golanglint-ci action

* chore(deps): Upgrade setup-go
  • Loading branch information
ezimanyi authored Sep 16, 2020
1 parent 8c3fd83 commit da09e3d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Install Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
- name: Ensure packages and dependencies compile
Expand All @@ -22,7 +22,12 @@ jobs:
run: go test ./...
- name: Ensure autogenerated protos match checked-in protos
run: make checkproto
golangci:
if: startsWith(github.repository, 'spinnaker/')
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Ensure code formatting and style is consistent
uses: golangci/golangci-lint-action@v1
uses: golangci/golangci-lint-action@v2
with:
version: v1.27
version: v1.31
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
fetch-depth: 0
- name: Install Go
uses: actions/setup-go@v1
uses: actions/setup-go@v2
with:
go-version: 1.15
- name: Create release
Expand Down

0 comments on commit da09e3d

Please sign in to comment.