-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D ui3 305 agis implement highlight for individual features e.g. from receive report #3529
D ui3 305 agis implement highlight for individual features e.g. from receive report #3529
Conversation
KatKatKateryna
commented
Jun 21, 2024
- Introduce struct holding LayerURI (represented as string because this is how native API is treating LayersURI), featureId, MapMember (actual layer object on the map)
- Adapt Report building and Highlight functionality to use this instead of flat string with LayerURI
- Add functionality to select individual features if FeatureID is available
…individual-features-e.g.-from-receive-report
…individual-features-e.g.-from-receive-report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I liked the extraction on object id which was always confusing for me, maybe I'm greedy but I believe we have an opportunity to have it more clean way. Then good to go 🚀
|
||
namespace Speckle.Connectors.ArcGIS.Utils; | ||
|
||
public struct ObjectID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would omit MapMember from this struct, it is confusing why objectID checks for MapMember as below.
if (objectId.MapMember == null)
{
continue;
}
What I expect from ObjectID
is just id, if you include MapMember it becomes something else. In this case, we might need another struct that has MapMember too instead considering its nullability on ObjectID
struct.
converting to draft to update documentation |
…individual-features-e.g.-from-receive-report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM 🚀