Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D ui3 305 agis implement highlight for individual features e.g. from receive report #3529

Conversation

KatKatKateryna
Copy link
Contributor

  1. Introduce struct holding LayerURI (represented as string because this is how native API is treating LayersURI), featureId, MapMember (actual layer object on the map)
  2. Adapt Report building and Highlight functionality to use this instead of flat string with LayerURI
  3. Add functionality to select individual features if FeatureID is available

@KatKatKateryna KatKatKateryna marked this pull request as ready for review June 24, 2024 12:32
…individual-features-e.g.-from-receive-report
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I liked the extraction on object id which was always confusing for me, maybe I'm greedy but I believe we have an opportunity to have it more clean way. Then good to go 🚀


namespace Speckle.Connectors.ArcGIS.Utils;

public struct ObjectID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would omit MapMember from this struct, it is confusing why objectID checks for MapMember as below.

if (objectId.MapMember == null)
{
   continue;
}

What I expect from ObjectID is just id, if you include MapMember it becomes something else. In this case, we might need another struct that has MapMember too instead considering its nullability on ObjectID struct.

@KatKatKateryna
Copy link
Contributor Author

converting to draft to update documentation

@KatKatKateryna KatKatKateryna marked this pull request as draft June 28, 2024 17:33
@KatKatKateryna KatKatKateryna marked this pull request as ready for review June 28, 2024 20:31
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 🚀

@oguzhankoral oguzhankoral merged commit 7d10c7f into dui3/alpha Jul 1, 2024
12 of 33 checks passed
@oguzhankoral oguzhankoral deleted the DUI3-305-AGIS-Implement-highlight-for-individual-features-e.g.-from-receive-report branch July 1, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants