Logger will not try and resolve path if not logging to disk #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlanRynne since this is no longer a blocker for the user. I don't think we should rush this one in, I'd like to test some more. |
AlanRynne
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our Logger will check that the logger directory exists on setup, even if the LogConfig has disk logging disabled.
This is causing some problems for users who are in environments other than windows/mac, or are in environments with no disk access.
User reports:
https://speckle.community/t/how-to-override-path-or-disable-specklelog/11705/3
https://speckle.community/t/speckle-unity-problems-in-android/9400
TODO: