Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNX-9501 agis highlighting loaded elements #3443

Merged
merged 5 commits into from
May 30, 2024
Merged

CNX-9501 agis highlighting loaded elements #3443

merged 5 commits into from
May 30, 2024

Conversation

KatKatKateryna
Copy link
Contributor

  • Save LayerURI instead of speckleId to Receive ModelCard, so selection/highlight method can find the layers in the host app
  • Add Table of Content (TOC) selection as well, because non-feature layers and Mulltipatch feature layer selections will not be visible on the canvas. Also, there might be multiple layers with the same shapes but different properties, just canvas selection might not be helpful

@KatKatKateryna
get URIs of received layers
19efbfb
@KatKatKateryna
add TOC selection (highlight) - because non-feature layers and multip…
fc8c3d0 
…atch feature layers will not be visible on the canvas. Also there might be multiple layers with the same shapes but different properties, just canvas selection might not be helpful
AlanRynne
AlanRynne approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say i know enough of ArcGIS api to fully understand it. But it looks good codewise

@oguzhankoral
Copy link
Member

@KatKatKateryna slowness on the selection fixed now?

@KatKatKateryna
Copy link
Contributor Author

@KatKatKateryna slowness on the selection fixed now?

it is

@AlanRynne AlanRynne changed the title Cnx 9501 agis highlighting loaded elements CNX-9501 agis highlighting loaded elements May 30, 2024
@AlanRynne AlanRynne merged commit 0920d7c into dui3/alpha May 30, 2024
34 checks passed
@AlanRynne AlanRynne deleted the CNX-9501-AGIS-Highlighting-loaded-elements branch May 30, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzhankoral oguzhankoral oguzhankoral approved these changes

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatKatKateryna @oguzhankoral @AlanRynne