DO NOT MERGE! Github Actions build + annotations test #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamhathcock
reviewed
May 7, 2024
.github/workflows/dotnet.yml
Outdated
| - name: Restore projects | ||
| run: dotnet restore DUI3-DX.slnf | ||
| - name: Build | ||
| run: msbuild DUI3-DX.slnf /p:Configuration=Release /p:IsDesktopBuild=false |
There was a problem hiding this comment.
not sure if this helps but using bullseye and C# instead of msbuild is what I do: https://github.com/adamralph/bullseye
There was a problem hiding this comment.
Nice! I've been eyeing some build systems for a while but didn't know about this one. Adding it to my "must look into" list!
There was a problem hiding this comment.
I like that the build is the same language as the project and not XML.
I used to use (and contribute) to Cake but thought it was overblown. Found bullseye and used it ever since dotnet got simple and fast
|
Closing to reduce noise, @adamhathcock has his branch ongoing and we'll see what we do with this once we reach somewhere meaningful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a PR to test a quick Github actions build pipeline I created last night.
we shouldn't actually merge this, it's just a POC. I need the PR to verify PR annotations are coming through and check if the result provides better DX for the team.