-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use relative path syntax #913
use relative path syntax #913
Conversation
To remove the entire RFC is a big change, considering this one already passed the OMG review. At this stage, I understand that the change should be minimal and as necessary. And the syntax for filename in RFC is more than just the prefix. |
Sorry, @bact, I must be misunderstanding something. How is any of the RFC relevant? The RFC talks about URIs, this field accepts filenames. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why URI syntax is relevant to file name syntax, not sure why it was included initially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the change - pending feedback from @zvr and @bobmartin3000 on impact to OMG review process
I'm fine to have the change. My concern is this is clearly not a change in a category of typo. The URI can be a filename, so there is no harm keeping it. But there can be a potential harm of prolonging the OMG review process. We defer a lot of issues and PRs in the past few months because of that OMG review reason. |
This is Bob username @bobmartin3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the process allows this to be in 3.0.1, please proceed.
Functionally we aren't changing anything with the removal of the reference to the RFC. I'm okay with the change but it is stretching the editorial change label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Require filenames to use the relative path syntax.
To fix #910