Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definitions of isFsfLibre and isOsiApprovied values #458

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Update definitions of isFsfLibre and isOsiApprovied values #458

merged 4 commits into from
Aug 12, 2023

Conversation

goneall
Copy link
Member

@goneall goneall commented Jul 31, 2023

Resolves issue #212

@goneall goneall requested review from zvr and swinslow July 31, 2023 23:46
kestewart
kestewart requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a verb was missed in a couple of the comment updates

model/ExpandedLicensing/Properties/isFsfLibre.md Outdated Show resolved Hide resolved
model/ExpandedLicensing/Properties/isOsiApproved.md Outdated Show resolved Hide resolved
@kestewart kestewart added the Profile:Licensing Licensing Profile and related matters label Aug 1, 2023
@kestewart kestewart added this to the 3.0-rc2 milestone Aug 1, 2023
@goneall
Add missing verb per review
671aea3 
Signed-off-by: Gary O'Neall <[email protected]>
@goneall
Copy link
Member Author

goneall commented Aug 1, 2023

@kestewart Thanks for the catch - fixed

maxhbr
maxhbr approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall
Copy link
Member Author

goneall commented Aug 6, 2023

@kestewart - if you could confirm it's all good, I'll merge

swinslow
swinslow reviewed Aug 6, 2023
View reviewed changes
Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @goneall, thanks for this. One typo below and one suggested wording tweak, otherwise LGTM.

model/ExpandedLicensing/Properties/isOsiApproved.md Outdated Show resolved Hide resolved
model/ExpandedLicensing/Properties/isOsiApproved.md Outdated Show resolved Hide resolved
@goneall
Fix grammer and spelling
2718669 
Signed-off-by: Gary O'Neall <[email protected]>
@goneall
Copy link
Member Author

goneall commented Aug 12, 2023

@kestewart @swinslow - I fixed the grammar and spelling errors - please take another look and if it looks good and approved, I'll merge.

@goneall
Update per suggestions
c8b3c0f 
Signed-off-by: Gary O'Neall <[email protected]>
@goneall goneall merged commit e7838ef into main Aug 12, 2023
1 check passed
@goneall goneall deleted the issue212 branch August 12, 2023 21:06
@goneall goneall mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kestewart kestewart kestewart requested changes

@maxhbr maxhbr maxhbr approved these changes

@swinslow swinslow swinslow approved these changes

@zvr zvr Awaiting requested review from zvr

Assignees
No one assigned
Labels
Profile:Licensing Licensing Profile and related matters
Projects
None yet
Milestone
3.0-rc2
Development

Successfully merging this pull request may close these issues.
4 participants
@goneall @swinslow @maxhbr @kestewart