Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PresenceType to core #450

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Move PresenceType to core #450

merged 1 commit into from
Aug 1, 2023

Conversation

goneall
Copy link
Member

@goneall goneall commented Jul 30, 2023

Fixes #416

@goneall
Move PresenceType to core
195a10c 
Fixes #416

Signed-off-by: Gary O'Neall <[email protected]>
@goneall goneall added Profile:Core Core Profile and related matters Profile:AI Artificial Intelligence Profile and related matters Profile:Dataset Dataset Profile and related matters labels Jul 30, 2023
@goneall goneall added this to the 3.0-rc2 milestone Jul 30, 2023
@goneall goneall self-assigned this Jul 30, 2023
kestewart
kestewart approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

maxhbr
maxhbr approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and consistent

@goneall goneall merged commit 97af34f into main Aug 1, 2023
1 check failed
@goneall goneall deleted the issue416 branch August 1, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kestewart kestewart kestewart approved these changes

@maxhbr maxhbr maxhbr approved these changes

@iamwillbar iamwillbar Awaiting requested review from iamwillbar

Assignees

@goneall goneall

Labels
Profile:AI Artificial Intelligence Profile and related matters Profile:Core Core Profile and related matters Profile:Dataset Dataset Profile and related matters
Projects
None yet
Milestone
3.0-rc2
Development

Successfully merging this pull request may close these issues.

Define Dataset/PresenceType
3 participants
@goneall @maxhbr @kestewart