Add customIdToUri Map to LicenseExpression #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2023
Fixes #380 Signed-off-by: Gary O'Neall <[email protected]>
zvr
approved these changes
Aug 13, 2023
maxhbr
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
I think this technically accomplishes its goal and improves the state and therefore can be merged
But I am afraid that this adds even more complexity to an already hard to grasp concept.
And the current model does not avoid duplicate keys and does not handle them if they would appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380
Implements suggestion made in this comment.
See this comment for an example serialization in JSON.