This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
fix/internal/grpc/retry/testpb: fix NPE in vendored testpb package interceptor_suite.go #64199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
team/product-platform
team/source
…terceptor_suite.go
ggilmore
force-pushed
the
graphite-ggilmorefeature_internal_grpc_retry_vendor_go-grpc-middleware_testing_testpb_package
branch
from
4e40431
to
ded7187
Compare
ggilmore
force-pushed
the
graphite-ggilmorefix_internal_grpc_retry_testpb_fix_npe_in_vendored_testpb_package_interceptor_suite.go
branch
from
09f854c
to
3153dc0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
net.Listencall fails, the returned listener will be nil and the error will never be printed.This PR fixes the issue by adding the
if err != nilcheck before we try to access the listener.Test plan
N/A - this is a vendored package
Changelog