-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve own test coverage and remove brittle expected_mutants_for_own_source_tree #296
Conversation
a0238fe
to
106095b
Compare
839c5a0
to
fe1dd62
Compare
It's a bit oversensitive and might be hiding other coverage gaps, and is a bit annoying to update every time. Fixes #295
Covers one mutants gap
The condition was written as `<` but `!=` is really all we care about
This inherently looks ath the environment - something has to - and this seems like a good way to test it.
And more tests
cargo-mutants filed that nothing depended on this, and I can't see any way it ever gets set.
5da8e02
to
f0fc9d4
Compare
There are now some timeouts in 93a850f:
(possibly more) They seem to all originate in Perhaps this is because they're all running in the source tree, and having trouble locking files there? |
Trying to bisect for the change that started this:
|
Apparently one cause of the hangs was sourcefrog/nutmeg#16, a cute deadlock in Nutmeg, avoided for now by not sending trace messages while rendering progress. |
This brittle test was hiding some mutants that were not otherwise well tested: coverage is better with the additions in this PR.
Also, this test needed to be updated on many commits, which was tedious and in hindsight a bad smell.
Fixes #295