-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all validators to handle Validation tasks #1093
base: main
Are you sure you want to change the base?
Conversation
For testing these changes I used the scripts and examples contained here: Unpacking this in a BenchExec clone will allow you to run all make targets called |
…e, with an indication that it is a witness inside the options field See https://gitlab.com/sosy-lab/benchmarking/sv-benchmarks/-/blob/36ba9aa5c3f5d7b52c7f1431a2fff287ebc7e5d9/c/loop-invariants/linear-inequality-inv-a.yml for an example task
…ot passed through it, but instead through the additional options
…elper functions This was done in preparation of changing all other tool-info modules which will depend on the helper functions
bb84d06
to
e378809
Compare
The code is fine for me now, thanks! However, I would still prefer if someone independent has a quick look at all the tool-info modules and compares the old and new code to check whether for example the correct enum value is passed, whether the options are inserted correctly, and whether the input files are taken correctly from the result of the new function. The reviewer would not need to be familiar with the existing code nor would they need to look at the code of |
Dear All, Many thanks for the great work done here. |
This PR depends on the format in https://gitlab.com/sosy-lab/benchmarking/sv-benchmarks/-/merge_requests/1572, so unless that is accepted it should not be merged anyway. |
…ins a witness option This is required, in order to make use of the validation tasks in SV-COMP with little changes in the pipeline and at the same time allow validators to validate only the validation tasks independent from the competition
@marian-lingsch Did you find a reviewer for #1093 (comment) already? |
What is the URL for the description of this |
I saw that @sim642 and @danieldietsch did some pass over the files, but will look for someone to do a full review |
This addresses the renaming of the option identifying the witness in the input files caused by: https://gitlab.com/sosy-lab/benchmarking/sv-benchmarks/-/merge_requests/1592
…-Benchmarks Addresses: #1093 (comment)
Thanks for pointing this out! Addressed in b550e76 |
The goal of this PR is to add support for validation tasks, whose format is described in: https://gitlab.com/sosy-lab/benchmarking/sv-benchmarks/-/merge_requests/1572
The goal is to make every validator be able to handle this tasks in time for SV-COMP25. This was discussed in the SV-COMP community meeting on the 2024-10-22 under point 6, see: https://docs.google.com/document/d/1A-GSaImjWSMbspERfOVAInmsjw3_tkIuAcHshn98Ro8/edit?tab=t.0#heading=h.3q9vj3p8sr3g
This PR implements the support for all validators, by creating some helper functions and adjusting all tool info modules of current validators to handle the new validation task definition files.
More concretely, given a validation task definition files such as the one below, what a validator needs to do is separate the witness file from other input files and use handle each of these two separate types of input files accordingly.
To remain backwards compatible with the previous usage of validators, we consider four possible cases:
--witness
present)--witness
not present)