Use env variables to setup #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
reviewed
Apr 20, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| function getRow($currency_from, $currency_to, $amount){ | |||
| // build URL | |||
| $url = "https://v6.exchangerate-api.com/v6/f3a28ea08292d915f7e45eee/pair/" . $currency_from . "/" . $currency_to; | |||
| $url = "https://v6.exchangerate-api.com/v6/" . getenv('API_KEY') . "/pair/" . $currency_from . "/" . $currency_to; | |||
There was a problem hiding this comment.
If no env var is set it should use f3a28ea08292d915f7e45eee as the default.
sorenlouv
reviewed
Apr 20, 2022
|
|
||
| if(!empty($matches)){ | ||
|
|
||
| $amount = $matches[1]; | ||
| $currency_from = $matches[2]; | ||
| $currency_to = isset($matches[3]) ? $matches[3] : $default_currency; | ||
| $currency_to = isset($matches[3]) ? $matches[3] : getenv('DEFAULT_CURRENCY'); |
There was a problem hiding this comment.
If no DEFAULT_CURRENCY env var is set it should have a built in default
|
Hi @whitte-h Thanks for the PR. I added some feedback. LMK what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes