Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in edgy rect placement in updateBinSize() #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugs in edgy rect placement in updateBinSize() #56

wants to merge 1 commit into from

Conversation

JohannesHoffmann
Copy link

@JohannesHoffmann JohannesHoffmann commented Mar 13, 2023 •
edited
Loading

This solves the bugs in #55

What have i done:

  • added fit or not fit check in extra test on rotated node to check for its better choice
  • removes padding on fit comparisons

I have doubts with the padding issue and my solution. It rotates only the fourth why not all? Is my solution correct?

@JohannesHoffmann
Copy link
Author

JohannesHoffmann commented Mar 13, 2023 •
edited
Loading

I have a questin right here. I struggled a lot to reproduce the bugs because in maxrects-packer.ts the option for square is false and in maxrects-bin.ts the same option is true. Was hard to find this out. Should this be the same default options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohannesHoffmann