Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about changing permissions for the built bootstrap file.
In the last released tag (https://github.com/softprops/serverless-rust/releases/tag/v0.3.8) integer
755
value is usedserverless-rust/index.js
Line 152 in c17cb6c
In the latest master octal
0o755
value is used: https://github.com/softprops/serverless-rust/blob/master/index.js#L172But this also causes some issues. Ways to reproduce:
hello
rust lambda function:npx serverless invoke local -f hello
target/lambda/release/lambda.zip
usingunzip
command:target/lambda/release/lambda.zip
just by double-clicking on it. But extractedbootstrap
will have wrong permissions in this case (-r--r--r--
so execute permission is missing):The issue is fixed with this PR.