Change logic for generating import statement #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasegao
commented
Sep 1, 2024
Comment on lines
+109
to
+110
| else: | ||
| break |
There was a problem hiding this comment.
If the parent paths are different, the loop should exit.
kasegao
commented
Sep 1, 2024
| # common/a/name.proto includes common/b/include.proto | ||
| # The basic name: include_p2p | ||
| module_name: str = message_path_list[-1].replace(".proto", "") + self.config.file_name_suffix | ||
| # Add non-shared parts: b.include_p2p | ||
| module_name = ".".join(message_path_list[index + 1 : -1] + (module_name,)) | ||
|
|
||
| logger.info((self._fd.name, other_fd.name, index)) | ||
| if index != -1: |
There was a problem hiding this comment.
When importing generated files from the destination project, paths should always be relative, even if they start from the root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #62
The original logic had issues generating import statements in some cases where only the intermediate paths matched (for details, please see issue #62).
This PR contains two changes.
First, it fixes the relative import bug described in #62.
Second, it makes sure that imports are relative even when importing from the root. This helps with path resolution when importing generated code from the destination project.