Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1794381: session api improvements #2642

Merged

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Nov 18, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1794381

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR adds the following to Session class

    • property version to get current snowpark client version.
    • class method get_active_session and getActiveSession that return the current active session or None is there are no active sessions.

@sfc-gh-aalam sfc-gh-aalam changed the title add test SNOW-1794381: session api improvements Nov 18, 2024
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review November 18, 2024 20:08
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners November 18, 2024 20:08
@sfc-gh-aalam sfc-gh-aalam merged commit f14cdb4 into main Nov 19, 2024
37 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1794381-api-coverage-session-improvements branch November 19, 2024 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants