Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1812949 add get object and get bytes support for native arrow structured types #1968

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik commented Nov 18, 2024

Add getObject and getBytes implementations for native arrow structured types

SNOW-1812949

The getString unification was already introduced to JDBC driver. This PR introduces changes for getObject and getBytes functions:

  • toObject on structure types would return object cast of StructObjectWrapper that contains both Object and String representation - to take the advantage of structure type and allow casting to Map or Array but also keep the backward compatibility with semi-structured types and return proper string representations
  • toBytes returns toBytes of the string representation of a structured type
  • also toBytes got added to the vector type as it wasn't available

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants