Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-969200: Default logpath to home directory instead of temp directory #1560

Merged
merged 1 commit into from
Nov 14, 2023
Merged

SNOW-969200: Default logpath to home directory instead of temp directory #1560

merged 1 commit into from
Nov 14, 2023

Conversation

sfc-gh-igarish
Copy link
Collaborator

Overview

SNOW-969200
Change the default LogPath to home directory if not specified in the config file. Previously it was default to temp directory.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-igarish sfc-gh-igarish requested a review from a team as a code owner November 14, 2023 17:57
@sfc-gh-igarish sfc-gh-igarish self-assigned this Nov 14, 2023
@sfc-gh-igarish sfc-gh-igarish merged commit 0ad9727 into master Nov 14, 2023
12 of 14 checks passed
@sfc-gh-igarish sfc-gh-igarish deleted the igarish-SNOW-969200-remove-temp-directory-config-file-part-2 branch November 14, 2023 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jtang sfc-gh-jtang sfc-gh-jtang approved these changes

@sfc-gh-bli sfc-gh-bli Awaiting requested review from sfc-gh-bli

Assignees

@sfc-gh-igarish sfc-gh-igarish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-igarish @sfc-gh-jtang