Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDBC_JAR_NAME to client environment #1547

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

sfc-gh-skumbham
Copy link
Contributor

Overview

Adds jar name with version to the client env. Sample output in the backend:

"clientEnvironment": "{\"schema\":\"PUBLIC\",\"tracing\":\"all\",\"role\":\"accountadmin\",\"OS\":\"Mac OS X\",\"OCSP_MODE\":\"FAIL_OPEN\",\"JAVA_VM\":\"OpenJDK 64-Bit Server VM\",\"APPLICATION\":\"\",\"warehouse\":\"rrj_wh\",\"database\":\"\",\"\":\"****\",\"JDBC_JAR_NAME\":\"snowflake-jdbc-fips-3.13.34\",\"OS_VERSION\":\"10.16\",\"serverURL\":\"[/](/)\",\"JAVA_VERSION\":\"11.0.11\",\"user\":\"\",\"account\":\"\",\"JAVA_RUNTIME\":\"OpenJDK Runtime Environment\"}"

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-skumbham sfc-gh-skumbham requested a review from a team as a code owner October 27, 2023 19:01
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-skumbham sfc-gh-skumbham merged commit a9784a9 into master Oct 27, 2023
12 of 14 checks passed
@sfc-gh-skumbham sfc-gh-skumbham deleted the skumbham-add-client-env branch October 27, 2023 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants