Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-919389: match dependencies versions for both pom.xml files #1543

Closed
wants to merge 2 commits into from

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl commented Oct 25, 2023

Overview

SNOW-919389
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/660

All dependencies versions are matched between pom.xml and FIPS/pom.xml

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

pom.xml

  • aws-java-sdk 1.12.327 -> 1.12.501
  • netty-buffer/netty-common 4.1.82.Final -> 4.1.100.Final
  • commons-compress: 1.21 -> 1.23.0

FIPS/pom.xml

  • slf4j 1.7.36 -> 2.0.6
  • httpclient 4.5.11 -> 4.5.14
  • httpcore 4.4.13 -> 4.4.16
  • google-api-client 1.33.2 -> 2.2.0
  • google-http-client/google-http-client-gson 1.43.2 -> 1.43.3
  • netty-buffer/netty-common 4.1.77.Final -> 4.1.100.Final
  • junit 4.13.1 -> 4.13.2
  • hamcrest-core 1.3 -> 2.2
  • hamcrest 2.1 -> 2.2
  • commons-codec 1.11 -> 1.15
  • commons-io 2.7 -> 2.11
  • jackson-dataformat-cbor 2.12.6 -> 2.14.2
  • jackson-databind 2.13.4.2 -> 2.14.2
  • guava 32.0.0-jre -> 32.1.1-jre
  • gson 2.9.0 -> 3.23.3
  • protobuf-java/protobuf-java-util 3.23.2 -> 3.23.3
  • commons-lang3 3.11 -> 3.12.0
  • logback-classic 1.2.3 -> 1.3.6
  • google-auth-library-oauth2-http 1.12.1 -> 1.19.0
  • google-cloud-storage 2.22.5 -> 2.22.6
  • google-auth-library-credentials 1.15.0 -> 1.19.0
  • google-oauth-client 1.33.3 -> 1.34.1

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl marked this pull request as ready for review October 26, 2023 06:43
@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner October 26, 2023 06:43
<jsoup.version>1.15.3</jsoup.version>
<tika.version>2.4.1</tika.version>
<jackson.version>2.14.2</jackson.version>
<jacksondatabind.version>2.13.4.2</jacksondatabind.version>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jacksondatabind becomes the same version as jackson.version

<bouncycastle.version>1.74</bouncycastle.version>
<google.api.client.version>1.34.0</google.api.client.version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is not used in this file.

@sfc-gh-ext-simba-jl
Copy link
Collaborator Author

Going to use PR #1546. Closing this one.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants