Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1050418] OktaAuthenticator refactor part1 #858

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SzymonSmykala
Copy link

@SzymonSmykala SzymonSmykala commented Jan 31, 2024

Description

Cleaned up OktaAuthenticator, and prepared for refactoring for object-oriented code.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@SzymonSmykala SzymonSmykala requested a review from a team as a code owner January 31, 2024 20:31
Copy link

github-actions bot commented Jan 31, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SzymonSmykala
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@SzymonSmykala
Copy link
Author

Coding conventions under link: https://github.com/snowflakedb/snowflake-connector-net/CodingConventions.md not found

@sfc-gh-knozderko
Copy link
Collaborator

Hi @SzymonSmykala could you please provide some context of your changes?
Is it just a refactor or you would like to introduce some new functionality? Do you have any business need related to this changes? It's called "part 1" so I suppose you would like to add/refactor more. Could you for example create a Github issue with the high level description what you would like to achieve and link your PR with it? Knowing the broader context would help us a lot. Thanks.

@SzymonSmykala
Copy link
Author

Hi @SzymonSmykala could you please provide some context of your changes? Is it just a refactor or you would like to introduce some new functionality? Do you have any business need related to this changes? It's called "part 1" so I suppose you would like to add/refactor more. Could you for example create a Github issue with the high level description what you would like to achieve and link your PR with it? Knowing the broader context would help us a lot. Thanks.

That's in progress, let me create a GitHub issue.

@SzymonSmykala SzymonSmykala changed the title OktaAuthenticator refactor part1 [SNOW-1050418] OktaAuthenticator refactor part1 Feb 9, 2024
@SzymonSmykala
Copy link
Author

@sfc-gh-knozderko Here it is : #864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants