Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes asset tag if 2D code is not present #15817

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 14, 2024

Description

The asset tag comes free when a QR code is used.
image

But if the QR code is not present the asset tag would be placed in an awkward place.
image

If a QR code is not being used the asset tag will have to be in a field space now:
image

These changes are applied to the following labels:
LabelWriter_1933081
LabelWriter_2112283
LabelWriter_30252

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Elimination of Unnecessary PDF Tags
    Removed a condition in the code that uselessly added text tags into the PDF file in certain circumstances. Now, the system won't call the function writeText() when this condition is not fulfilled, optimizing the performance and speed of PDF file generation.

@Godmartinz Godmartinz marked this pull request as draft November 14, 2024 17:44
@Godmartinz Godmartinz marked this pull request as ready for review November 14, 2024 19:13
@snipe snipe merged commit f2faf58 into snipe:develop Nov 14, 2024
9 checks passed
@snipe
Copy link
Owner

snipe commented Nov 14, 2024

I only see two files changed here, and am still seeing this with LabelWriter_1933081.

Screenshot 2024-11-14 at 8 54 02 PM

snipe added a commit that referenced this pull request Nov 14, 2024
@snipe
Copy link
Owner

snipe commented Nov 14, 2024

I patched LabelWriter_1933081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants