Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor companyable #15814

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Refactor companyable #15814

wants to merge 6 commits into from

Commits on Nov 14, 2024

  1. Companyable fully switched over, tests pass

    @uberbrady
    uberbrady committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b90c8fc View commit details
    Browse the repository at this point in the history

  2. Handled CompanyableChild

    @uberbrady
    uberbrady committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4e50b5f View commit details
    Browse the repository at this point in the history

  3. Reduce repetition a little

    @uberbrady
    uberbrady committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4d95657 View commit details
    Browse the repository at this point in the history

  4. Remove one more dependency

    @uberbrady
    uberbrady committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a3cf1f1 View commit details
    Browse the repository at this point in the history

  5. Final (hopefully) cleanup

    @uberbrady
    uberbrady committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5e88815 View commit details
    Browse the repository at this point in the history

  6. No need to unnecessarily refactor these, back it out

    @uberbrady
    uberbrady committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    437f4f5 View commit details
    Browse the repository at this point in the history