Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to label #924

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

feat: add link to label #924

wants to merge 49 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 22, 2024

Summary

Depends on #910

This PR enable label to link to the proposal page, filtered by the given label

How to test

  1. Go to a space proposals page with labels
  2. Click on label in the proposals title
  3. It should redirect to the proposals page, with the given label filter
  4. Repeat same steps, for label inside the single proposal page

@wa0x6e wa0x6e marked this pull request as ready for review October 22, 2024 17:15
@wa0x6e wa0x6e requested a review from ChaituVR October 22, 2024 17:15
apps/ui/src/components/ProposalLabels.vue Outdated Show resolved Hide resolved
apps/ui/src/components/Ui/ProposalLabel.vue Outdated Show resolved Hide resolved
Base automatically changed from feat-filters-proposals-by-label to master November 3, 2024 11:47
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck (tested it previously)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants