Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect logged user to home #709

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Sep 4, 2024

Summary

This PR restore feature from #640

How to test

  1. Go to / as a guest user
  2. You should see the home page
  3. Go to / as a logged in user
  4. You should be redirect to /home

@wa0x6e wa0x6e marked this pull request as draft September 4, 2024 13:09
@bonustrack
Copy link
Member

The flashing landing page is a bit annoying, would be great to find a workaround

@wa0x6e wa0x6e marked this pull request as ready for review September 4, 2024 13:44
@wa0x6e wa0x6e marked this pull request as draft September 4, 2024 13:44
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Sep 4, 2024

Ideal solution would be to have a splash screen, which would show for the first 1 second, or when the app is ready (logged in, or when sure it's a guest), whichever come first.

From claude:

YouTube TV: When launching the web app, it shows a brief splash screen with the YouTube TV logo.

Slack: The desktop and web applications show a splash screen while loading.

Discord: The desktop and web apps display a splash screen during startup.

Some Google Web Applications: Certain Google apps like Google Docs or Google Sheets may show a brief splash screen when opening a document.

Trello: The web app shows a loading splash screen when initializing.

Notion: The web application displays a splash screen while loading.

He also recommended a few alternatives, the most I like is showing a skeleton screen

@bonustrack
Copy link
Member

bonustrack commented Sep 6, 2024

We can go with the splash screen but we will need to solve this first: #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants