feat : add badges #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier tests
Queue system enable back the cache file generation on demand when cache is not available on fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7
Space
Active proposals count
GET http://localhost:3000/badges/space/cakevote.ethClosed proposals count
GET http://localhost:3000/badges/space/cakevote.eth?state=closedPending proposals count
GET http://localhost:3000/badges/space/cakevote.eth?state=pendingFollowers count
GET http://localhost:3000/badges/space/cakevote.eth?field=followersCountProposal
GET http://localhost:3000/badges/proposal/0x013f763e92d253926bc7f04d79138593a1b31c969a34db7f0955e46850c796d9TODO
Some proposals counter does not appear on pngImage seem low-res, and not crisp enough, shields.io seems to have the same issue (e.g. https://raster.shields.io/badge/proposal-1,790-green). Tried to pass the SVG to different SVG->PNG libraries, as well as online services such as https://svgtopng.com/, everything return a low res picture. We could just abandon the .png route (and leave the low res image), and commit to svg format, like pretty much all the badge servicesAfter a market research, all badges provider are returning badge as SVG. We will only support and drop png support, due to issue with png image low resolution