Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: privacy field in proposal data #467

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: privacy field in proposal data #467

wants to merge 5 commits into from

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 29, 2024 •
edited
Loading

Towards https://github.com/snapshot-labs/workflow/issues/277

Summary

  • Accept privacy field if space's privacy is any
  • Else use space's privacy as default value
  • Reject if proposal has privacy and space is not using 'any'

How to test:

@ChaituVR ChaituVR mentioned this pull request Oct 29, 2024
Open
wa0x6e
wa0x6e reviewed Nov 2, 2024
View reviewed changes
src/writer/proposal.ts Outdated Show resolved Hide resolved
@ChaituVR ChaituVR marked this pull request as ready for review November 4, 2024 10:50
@ChaituVR ChaituVR marked this pull request as draft November 4, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e