Set necessary env for system gtk themes to work and clean up content interfaces #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit befe3db.
lucyllewy
reviewed
Jan 31, 2020
| @@ -81,6 +84,9 @@ environment: | |||
| LD_LIBRARY_PATH: $SNAP/usr/lib/$SNAPCRAFT_ARCH_TRIPLET/lapack:$SNAP/usr/lib/$SNAPCRAFT_ARCH_TRIPLET/blas:$LD_LIBRARY_PATH | |||
| PYTHONPATH: $SNAP/usr/lib/python2.7:$SNAP/usr/lib/python2.7/site-packages:$PYTHONPATH | |||
| FINAL_BINARY: $SNAP/usr/bin/gimp | |||
| GTK_PATH: $SNAP/lib/gtk-2.0 | |||
There was a problem hiding this comment.
Yes, it looks like the symlinks created in the gnome-extension part should be adjusted so we don't need to set GTK_PATH or GTK3 will be inoperable. (Line 170 and 171)
There was a problem hiding this comment.
Also see the GTK3 version linking into the platform snap on 167 and 168 for inspiration :-)
There was a problem hiding this comment.
does this break GTK3?
I don't think GTK3 uses GTK_PATH.
lucyllewy
requested changes
Jan 31, 2020
force symlinks Co-Authored-By: Daniel Llewellyn <[email protected]>
force symlinks Co-Authored-By: Daniel Llewellyn <[email protected]>
|
This is no longer relevant as far as I can tell, and already fixed on both the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also reverts a previous commit which disabled the usage of gtk2-common-themes. This was originally done because gtk2-common-themes was only built for amd64. We'll soon have gtk2-common-themes for all supported architectures.