Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature / remove handler from sdl remote display #859

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BrettyWhite
Copy link
Contributor

WIP

Fixes #858

This PR is not ready for review.

Risk

This PR makes no API changes.

Testing Plan

[Describe how you plan to unit test the changes in this PR]

Summary

Handle keep alive logic in the encoder. This will be updated and fixed in a future release

CLA

into the virtual display encoder.
@codecov-io
Copy link

Codecov Report

Merging #859 into develop will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #859      +/-   ##
=============================================
+ Coverage      44.63%   44.64%   +0.01%     
- Complexity      3187     3189       +2     
=============================================
  Files            399      399              
  Lines          18196    18220      +24     
  Branches        1761     1765       +4     
=============================================
+ Hits            8121     8135      +14     
- Misses          9745     9751       +6     
- Partials         330      334       +4
Impacted Files Coverage Δ Complexity Δ
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 4.64% <0%> (-0.01%) 6 <0> (ø)
...smartdevicelink/encoder/VirtualDisplayEncoder.java 30.24% <50%> (+5.53%) 10 <2> (+2) ⬆️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 63.33% <66.66%> (+0.09%) 5 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5deff97...419df42. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants