Feature/Restructuring OnResetTimeout #2754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL must send GENERIC_ERROR to app in case HMI does NOT respond during <DefaultTimeout>+<RPCs_internal_timeout> for all RPCs with own timer
For RPS with own timers SDL should apply default+internal timeout for mobile and HMI requests
In case when mobile send Alert request with soft buttons SDL must not apply OnResetTimeout logic
SDL should apply OnResetTimeout only in case when resetPeriod value is greater than the time remaining from the current timeout
LitvinenkoIra
force-pushed
the
feature/restructuring_OnResetTimeout
branch
from
f7afaa7
to
0cc571b
Compare
LuxoftAKutsan
approved these changes
Nov 22, 2018
|
Closed in favor of #3726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2422
This PR is ready for review.
❗ These changes are based on #2495 and this PR should be merged after #2495
Risk
This PR makes major API changes.
Testing Plan
Summary
Expand OnResetTimeout RPC for all interfaces.
Note: SDL will apply OnResetTimeout only in case when resetPeriod value is greater than the time remaining from the current timeout
Changelog
Breaking Changes
Other parts of delivery:
CLA