Chore/doc 150/remove vercel redirects #1300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fmonper1
requested review from
dwightjl,
ritika-b,
aelmanaa and
thedriftofwords
as code owners
dwightjl
reviewed
May 26, 2023
| @@ -10,397 +10,5 @@ | |||
| ] | |||
| } | |||
| ], | |||
| "cleanUrls": true, | |||
| "redirects": [ | |||
There was a problem hiding this comment.
Are these all duplicates with the Astro redirects? We might need to merge this list into the Astro redirects file and clean up duplicate entries.
There was a problem hiding this comment.
Yes, and we shouldn't be using vercel redirections at all with astro 2.0 https://vercel.com/docs/frameworks/astro#can-i-use-vercel.json-to-create-rewrites-with-astro
|
@fmonper1 Builds are working again after generating a fresh package-lock.json file but the new linkchecker is throwing errors. I'll take a look later and see if I can figure out why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we handle redirection in two ways.
This PR removes the redirects from the vercel config so that there is a single source of truth for our redirects and also introduces middleware for handling redirections at the edge.
Middlewares allow us to keep track of the page referrer by extracting the
refererheader from the http request and appending it to the destination url.Test url: https://documentation-git-chore-doc-150remove-verc-960820-chainlinklabs.vercel.app/docs/chainlink-keepers/introduction