fix: fixed incorrect wrap for process's stdio container #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdio api of the process should ensure the calling order.
According to libuv's documentation and test cases, where stdio[0] is designated as stdin, stdio[1] as stdout, and stdio[2] as stderr.
When specifying stdin for the child process as stdin_pipe, stdout to a custom file, and stderr as stderr_pipe:
process_handle.stdio(stdin_pipe, flag)
process_handle.stdio(stdout_file_handle, flag)
process_handle.stdio(stderr_pipe, flag)
The previous uvw implementation incorrectly concatenates it as follows because it used two vectors seperately:
stdio[0] = stdout_file_handle
stdio[1] = stdin_pipe
stdio[2] = stderr_pipe
This is not the correct behaviour
This PR try to fix this.😊
Libuv spawn examples: https://github.com/libuv/libuv/blob/v1.x/test/test-spawn.c