update makefile to account for different arch

[ugwuanye]

Changes

update makefile to account for different arch

Issue link

closes #91

[aecay]

Can you describe the usecase you are aiming to account for? End users should install osprey through the github downloads page (example for the latest release version; under the "assets" dropdown) -- which already includes binaries for amd and arm architectures.

For local development on macs, the built-in amd64 emulation should be sufficient (which anyway should not be a use case to which our users are exposed). Absent a use case, I am not sure if we need to be making any changes to the makefile in this case. I'm eager to hear more though about the motivations for this PR.

[ugwuanye]

@aecay I think it is an ehancement to include other architectures. This is because the current task assumes that anyone that uses the makefile is running amd64 which is probably not the case.
You are right this update is not targeted for users who downloads the tool from github asserts.

[aecay]

On my ARM Mac, when I run make build in a fresh clone of this repo and then run ./build/bin/darwin_amd64/osprey --help, the binary executes correctly. This is because ARM macs have amd64 emulation built in. The environments where our developers work are expected to be amd64 mac or win and arm macs. So all the possibilities are covered. I'm not convinced by the tradeoffs of adding exotic architectures such as i386 to our code base. It makes the code more complicated, without any benefit.

Did you run into architecture compatibility problems on your machine while attempting to complie osprey from source? What steps did you take that led to that outcome?

[zemanlx]

I think we should be able to to drop GOARCH (and GOOS) from the Makefile and it just works and compiles for whatever architecture and OS developer currently have

$ echo $GOOS:$GOARCH  
:
$ go env GOOS GOARCH 
darwin
amd64