Acurl use Cython 3.0.8 #280
Conversation
| @@ -32,7 +32,7 @@ cdef BufferNode* alloc_buffer_node(size_t size, char *data): | |||
| node.next = NULL | |||
| return node | |||
|
|
|||
| cdef size_t header_callback(char *ptr, size_t size, size_t nmemb, void *userdata): | |||
| cdef size_t header_callback(char *ptr, size_t size, size_t nmemb, void *userdata) noexcept: | |||
There was a problem hiding this comment.
OTOH, this function (and the one below it in this file) really can't raise, and so are valid noexcept candidates with no explanation needed.
| @@ -26,7 +26,8 @@ install_requires = | |||
| nanomsg | |||
| pyzmq | |||
| selenium<4 | |||
| uvloop | |||
| setuptools | |||
| uvloop==0.21.0b1 | |||
There was a problem hiding this comment.
hmm, do we know why we are pinning to a specific version, especially a beta one? what are the conditions in the future under which we could remove the pin?
| @@ -14,4 +14,4 @@ pytest-httpbin | |||
| pytest-httpserver | |||
| sanic | |||
| werkzeug==3.0.3 | |||
| uvloop==0.19.0 | |||
| uvloop==0.21.0b1 | |||
There was a problem hiding this comment.
eek -- the test should not be pinned to a different version than the main code, so it's good to change this (tho no pinning would be ideal).
it's been a while since i looked at this code, but IIRC, the tests install everything from setup.cfg as well as everything from the test-requirements.txt. so given that uvloop is already required by setup.cfg, we could delete it from here and avoid any future iterations of the different-pinning problem. WDYT?
There was a problem hiding this comment.
I was getting errors due to it not the version of uvloop required for Cython 3. (This commit). Which is why I pinned it to version 0.21.0b1. I'll put this PR back in drafts whilst I fix them etc.
There was a problem hiding this comment.
ahhh, uvloop doesn't have a stable release for cython3 yet. that explains it. do we want to wait for upstream to cut a stable release? that should avoid us needing to do any pinning. if we don't want to wait, we can just stick a comment in explaining the situation, and Someone™ can remove the comment and the pin in the future....
What is the change?
Add compatibility for Cython version greater than 3.
Does this change require a version increment:
This is only a version increment for acurl, done in the
acurl/setup.cfgfile. Not mite itself.