Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TagLatency match gin-gonic/gin format #19

Closed
wants to merge 1 commit into from

Conversation

sixcolors
Copy link
Owner

Description

TagLatency to match gin-gonic/gin defaultLogFormatter, specifically %13v instead of %7v.

With %7v:

| 4.834µs |
| 1.136834ms |
| 1.000066333s |

With %13v:

|       4.333µs |
|    1.133916ms |
|  1.000057458s |

And, adds Test_Logger_WithLatency, which proves that the logger would show he smallest unit that makes sense. (except for ns, which is probably too fast for most systems to test).

Fixes gofiber#2561

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@sixcolors sixcolors closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [Feature]: Log show lowerst time-unit that makes sense [#2258]
1 participant